Skip to content

fix(deps): add typings to dependencies #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(deps): add typings to dependencies #168

wants to merge 1 commit into from

Conversation

filipesilva
Copy link
Contributor

angular-cli now has a postinstall script that uses typings, but this package is listed as a devDependency and thus install fails.

This PR moves typings to a normal dependency.

@Brocco
Copy link
Contributor

Brocco commented Feb 1, 2016

Based on conversation, lets just remove the postinstall script instead, and devs can manually install typings for now

@filipesilva
Copy link
Contributor Author

Roger.

@filipesilva filipesilva closed this Feb 1, 2016
@filipesilva filipesilva mentioned this pull request Feb 1, 2016
Merged
@IgorMinar
Copy link
Contributor

good decision! thanks

@filipesilva filipesilva deleted the typings-fix branch June 13, 2016 16:12
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipesilva @Brocco @IgorMinar